Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add VoteInfos to context in BeginBlock #15403

Merged
merged 3 commits into from
Mar 15, 2023
Merged

feat: Add VoteInfos to context in BeginBlock #15403

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25d9f49
feat: Add VoteInfos to context in BeginBlock
facundomedica Mar 15, 2023
7d4babc
suggestion from @julienrbrt
facundomedica Mar 15, 2023
6c2e213
Merge branch 'main' into facu/add-votesctx
facundomedica Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion baseapp/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg
app.deliverState.ctx = app.deliverState.ctx.
WithBlockGasMeter(gasMeter).
WithHeaderHash(req.Hash).
WithConsensusParams(app.GetConsensusParams(app.deliverState.ctx))
WithConsensusParams(app.GetConsensusParams(app.deliverState.ctx)).

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call
WithVoteInfos(req.LastCommitInfo.GetVotes())

if app.checkState != nil {
app.checkState.ctx = app.checkState.ctx.
Comment on lines 196 to 203
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change potentially affects state.

Call sequence:

(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).BeginBlock (baseapp/abci.go:166)

Expand Down