chore: revert panic in simapp #15367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Mar 13, 2023
simapp/simd/main.go
Outdated
| @@ -9,6 +12,7 @@ import ( | |||
| func main() { | |||
| rootCmd := cmd.NewRootCmd() | |||
| if err := svrcmd.Execute(rootCmd, "", simapp.DefaultNodeHome); err != nil { | |||
| panic(err) | |||
| log.NewLogger(rootCmd.OutOrStdout()).Error("failure when running app", "err", err) | |||
There was a problem hiding this comment.
I still feel like we should display the error (which wasn't the case before the panic addition)
There was a problem hiding this comment.
Yes, this is correct. Most cobra apps will print the error to STDERR and then os.Exit(1).
alexanderbez
approved these changes
Mar 13, 2023
simapp/simd/main.go
Outdated
| @@ -9,6 +12,7 @@ import ( | |||
| func main() { | |||
| rootCmd := cmd.NewRootCmd() | |||
| if err := svrcmd.Execute(rootCmd, "", simapp.DefaultNodeHome); err != nil { | |||
| panic(err) | |||
| log.NewLogger(rootCmd.OutOrStdout()).Error("failure when running app", "err", err) | |||
There was a problem hiding this comment.
Yes, this is correct. Most cobra apps will print the error to STDERR and then os.Exit(1).
facundomedica
approved these changes
Mar 13, 2023
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #15358 (comment)
Right, panic gives exit code 2.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change