Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling cosmovisor logs #15362

Merged
merged 7 commits into from
Mar 12, 2023

Conversation

freak12techno
Copy link
Contributor

@freak12techno freak12techno commented Mar 12, 2023

Description

Closes: #15359

Introduces DAEMON_DISABLE_LOGS env variable for Cosmovisor, when set to true, Cosmovisor won't write any logs into stdout. That is useful when you need to run a subcommand that returns a valid JSON but Cosmovisor's logging makes it invalid.
Additionally, I removed the logic with always disabled logging in cosmovisor version --output json, as this is redundant and isn't as flexible as the DAEMON_DISABLE_LOGS approach.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@freak12techno freak12techno requested a review from a team as a code owner March 12, 2023 12:26
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Mar 12, 2023
@freak12techno freak12techno force-pushed the allow-disabling-cosmovisor-logs branch from 0ccb855 to d999048 Compare March 12, 2023 12:27
CHANGELOG.md Outdated Show resolved Hide resolved
@freak12techno freak12techno requested review from julienrbrt and removed request for facundomedica and tac0turtle March 12, 2023 12:44
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Thank you, @freak12techno, could you mention that in the README.md?

tools/cosmovisor/args.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt merged commit 8f8afd1 into cosmos:main Mar 12, 2023
@freak12techno freak12techno deleted the allow-disabling-cosmovisor-logs branch March 12, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmovisor: be able to silence cosmovisor logs when running commands
2 participants