-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling cosmovisor logs #15362
Merged
julienrbrt
merged 7 commits into
cosmos:main
from
freak12techno:allow-disabling-cosmovisor-logs
Mar 12, 2023
Merged
feat: allow disabling cosmovisor logs #15362
julienrbrt
merged 7 commits into
cosmos:main
from
freak12techno:allow-disabling-cosmovisor-logs
Mar 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freak12techno
force-pushed
the
allow-disabling-cosmovisor-logs
branch
from
March 12, 2023 12:27
0ccb855
to
d999048
Compare
julienrbrt
reviewed
Mar 12, 2023
freak12techno
requested review from
julienrbrt
and removed request for
facundomedica and
tac0turtle
March 12, 2023 12:44
julienrbrt
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK.
Thank you, @freak12techno, could you mention that in the README.md?
julienrbrt
reviewed
Mar 12, 2023
19 tasks
19 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15359
Introduces DAEMON_DISABLE_LOGS env variable for Cosmovisor, when set to true, Cosmovisor won't write any logs into stdout. That is useful when you need to run a subcommand that returns a valid JSON but Cosmovisor's logging makes it invalid.
Additionally, I removed the logic with always disabled logging in
cosmovisor version --output json
, as this is redundant and isn't as flexible as the DAEMON_DISABLE_LOGS approach.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change