chore: make proto-gen due to dep update
#15268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Cosmovisor
julienrbrt
commented
Mar 6, 2023
| @@ -18,6 +18,10 @@ import ( | |||
| // Requires gRPC-Go v1.32.0 or later. | |||
| const _ = grpc.SupportPackageIsVersion7 | |||
|
|
|||
| const ( | |||
| Query_Config_FullMethodName = "/cosmos.app.v1alpha1.Query/Config" | |||
There was a problem hiding this comment.
The new protoc-gen-go-grpc v1.3.0 adds constants instead of reusing a string of the same argument.
This is the only change thorough the generated files.
julienrbrt
commented
Mar 6, 2023
| @@ -7,7 +7,7 @@ require ( | |||
| cosmossdk.io/client/v2 v2.0.0-20230220152935-67f04e629623 | |||
| cosmossdk.io/core v0.6.0 | |||
| cosmossdk.io/depinject v1.0.0-alpha.3 | |||
| cosmossdk.io/log v0.0.0-20230303183710-74c894f12720 | |||
| cosmossdk.io/log v0.0.0-20230305202224-89c956f8ed3a | |||
There was a problem hiding this comment.
Getting cosmossdk.io/[email protected]: invalid version: unknown revision 74c894f12720 on make install.
julienrbrt
commented
Mar 6, 2023
| @@ -1,6 +1,8 @@ | |||
| // Since: cosmos-sdk 0.46 | |||
There was a problem hiding this comment.
Weird but cool (the comment is in the proto file too).
tac0turtle
approved these changes
Mar 6, 2023
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15267
Updated log pseudo version as well as I was getting error while running
make install.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change