fix: Format decimals correctly for signmode textual #15129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundomedica
requested review from
webmaster128 and
amaury1093
and removed request for
JeancarloBarrios and
samricotta
amaury1093
reviewed
Feb 23, 2023
| ["123", "123"], | ||
| ["1234", "1'234"], | ||
| ["0.0", "0"], | ||
| ["1.0", "1"], |
There was a problem hiding this comment.
I remember when we introduced gov v1, we dropped the customtype to sdk.Dec, see here or tally. This means in state, the string is stored as a "normal" decimal.
What we need to make sure is that the string does always have a .. For example, we should test this manually with Ledger, using a weighted vote of 1, and make sure it shows 1 and not 1e-18.
There was a problem hiding this comment.
...Options (1/1)xWeightedVoteOption object�fOptionoVOTE_OPTION_YES�fWeighta1�nEnd of Options�nEnd of Message�iGas limitg200'000...
Looks fine 👌 Also for bank send it looks good.
amaury1093
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Impl LGTM, can merge if it's tested manually #15129 (comment)
Co-authored-by: Amaury <[email protected]>
facundomedica
commented
Feb 23, 2023
types/mempool/sender_nonce.go
Outdated
| func (mp *SenderNonceMempool) NextSenderTx(sender string) sdk.Tx { | ||
| senderIndex, ok := mp.senders[sender] | ||
| func (snm *SenderNonceMempool) NextSenderTx(sender string) sdk.Tx { | ||
| senderIndex, ok := snm.senders[sender] |
There was a problem hiding this comment.
changes to make the linter happy
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the issue with values being formatted as huge numbers. Like
--commission-rate="0.1"being shown as100'000'000'000'000'000.Warning: this is a workaround to a bigger issue regarding
sdk.Dec. Values that don't contain a "." will be processed as if they were Ne-18. We need to double-check if this affects anything elseRelated: #10863
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change