Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CLI metadata help text #15071

Merged
merged 3 commits into from
Feb 20, 2023
Merged

chore: CLI metadata help text #15071

merged 3 commits into from
Feb 20, 2023

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #15032


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review February 20, 2023 11:48
@atheeshp atheeshp requested a review from a team as a code owner February 20, 2023 11:48
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 20, 2023
@atheeshp atheeshp enabled auto-merge (squash) February 20, 2023 12:02
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 20, 2023
@atheeshp atheeshp merged commit 9e5e8ea into main Feb 20, 2023
@atheeshp atheeshp deleted the ap/cli-doc branch February 20, 2023 14:09
fedekunze pushed a commit that referenced this pull request Feb 20, 2023
julienrbrt pushed a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:CLI C:x/gov C:x/group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI help text for gov v1 proposal submission command can be misleading
3 participants