Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add message router interface #15035

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

tac0turtle
Copy link
Member

Description

Closes: #15023

provide an interface for message router instead of passing the direct type to modules

this is a stop gap until we land adr33


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review February 15, 2023 05:13
@tac0turtle tac0turtle requested a review from a team as a code owner February 15, 2023 05:13
@atheeshp
Copy link
Contributor

@tac0turtle gov, groups also using MsgServiceRouter, should we also update them to use interface?

@tac0turtle tac0turtle merged commit 1dad689 into main Feb 15, 2023
@tac0turtle tac0turtle deleted the marko/15023_add_interface branch February 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Interface instead of *baseapp.MsgServiceRouter in modules
5 participants