Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(collections): move codecs to separate package and add int keys. #15001

Merged
merged 24 commits into from
Feb 19, 2023
Merged

refactor(collections): move codecs to separate package and add int keys. #15001

merged 24 commits into from
Feb 19, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Feb 13, 2023 •
edited
Loading

Description

Closes: #15002

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review February 13, 2023 11:23
@testinginprod testinginprod requested a review from a team as a code owner February 13, 2023 11:23
@github-prbot github-prbot requested review from a team, alexanderbez and facundomedica and removed request for a team February 13, 2023 11:23
@testinginprod testinginprod marked this pull request as draft February 14, 2023 11:53
@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor labels Feb 17, 2023
testinginprod added 2 commits February 17, 2023 17:02
Merge branch 'main' into collections/refactors
784899e 
# Conflicts:
#	simapp/go.mod
#	x/upgrade/go.mod
gomod cleanups
460e829
@testinginprod testinginprod marked this pull request as ready for review February 17, 2023 16:04
@github-prbot github-prbot requested a review from a team February 17, 2023 16:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 17, 2023
View reviewed changes
tools/hubl/internal/load.go Outdated
@@ -44,7 +44,7 @@

func (c *ChainInfo) getCacheDir() (string, error) {
cacheDir := path.Join(c.ConfigDir, "cache")
return cacheDir, os.MkdirAll(cacheDir, 0755)
return cacheDir, os.MkdirAll(cacheDir, 0o755)

Check failure

Code scanning / gosec

Expect directory permissions to be 0750 or less

Expect directory permissions to be 0750 or less
tools/hubl/internal/config.go Outdated
@@ -49,12 +49,12 @@
return err
}

if err := os.MkdirAll(configDir, 0755); err != nil {
if err := os.MkdirAll(configDir, 0o755); err != nil {

Check failure

Code scanning / gosec

Expect directory permissions to be 0750 or less

Expect directory permissions to be 0750 or less
tools/hubl/internal/load.go Outdated
@@ -133,7 +133,7 @@
return err
}

err = os.WriteFile(appOptsFilename, bz, 0644)
err = os.WriteFile(appOptsFilename, bz, 0o644)

Check failure

Code scanning / gosec

Expect WriteFile permissions to be 0600 or less

Expect WriteFile permissions to be 0600 or less
tools/hubl/internal/load.go Outdated
@@ -92,7 +92,7 @@
return err
}

if err = os.WriteFile(fdsFilename, bz, 0644); err != nil {
if err = os.WriteFile(fdsFilename, bz, 0o644); err != nil {

Check failure

Code scanning / gosec

Expect WriteFile permissions to be 0600 or less

Expect WriteFile permissions to be 0600 or less
tools/hubl/internal/config.go Outdated
return err
}

configPath := configFilename(configDir)
if err := os.WriteFile(configPath, buf.Bytes(), 0644); err != nil {
if err := os.WriteFile(configPath, buf.Bytes(), 0o644); err != nil {

Check failure

Code scanning / gosec

Expect WriteFile permissions to be 0600 or less

Expect WriteFile permissions to be 0600 or less
@testinginprod testinginprod enabled auto-merge (squash) February 17, 2023 16:20
testinginprod added 2 commits February 19, 2023 13:43
Merge branch 'main' into collections/refactors
c37b8ba 
# Conflicts:
#	x/evidence/go.mod
#	x/feegrant/go.mod
#	x/upgrade/go.mod
merge
934ed69
@testinginprod testinginprod merged commit a9a9482 into main Feb 19, 2023
@testinginprod testinginprod deleted the collections/refactors branch February 19, 2023 13:06
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@testinginprod
refactor(collections): move codecs to separate package and add int ke…
75c1b33 
…ys. (cosmos#15001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees
No one assigned
Labels
C:collections C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(collections): add Int keys
2 participants
@testinginprod @tac0turtle