-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: moving value codecs to a single place #14912
Conversation
I think the change makes sense to me, in my head initially I though that a collections codec should live where we declare the type so that developers can find it easily. Otherwise another solution might be to declare every codec in the SDK in a single package. We just need to find a way to make the codecs findable by developers. |
I think for more used items yes, but generally would love to see a world where we don't use castTypes and other proto features in this way and only use native proto types. |
Description
This proposes moving the math value codec into types to reduce the dependency graph in math. Don't want to have collections as a dep for people who aren't using it in a small library
would love to hear feedback from @testinginprod, if this is okay
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change