-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce tendermint deps (backport #14616) #14664
refactor: reduce tendermint deps (backport #14616) #14664
Conversation
(cherry picked from commit 44fbb0d) # Conflicts: # crypto/ledger/ledger_mock.go # crypto/ledger/ledger_secp256k1.go # go.mod # go.sum # simapp/go.mod # simapp/go.sum # tests/go.mod # tests/go.sum # x/nft/go.mod # x/nft/go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
|
||
// Replicates https://github.com/cosmos/cosmos-sdk/blob/44fbb0df9cea049d588e76bf930177d777552cf3/crypto/ledger/ledger_secp256k1.go#L228 | ||
// DO NOT USE. This is a temporary workaround that is cleaned-up in v0.47+ | ||
func IsOverHalfOrder(sigS *big.Int) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elias-orijtech, this is a good replacement of
cosmos-sdk/crypto/ledger/ledger_secp256k1.go
Line 228 in 44fbb0d
if sModNScalar.IsOverHalfOrder() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, yes. ecdsa.IsSNormalized
calls big.Int.Cmp
which is not constant time. secp256k1.ModNScalar.IsOverHalfOrder
is designed to be constant time.
Co-authored-by: Julien Robert <[email protected]>
This is an automatic backport of pull request #14616 done by Mergify.
Cherry-pick of 44fbb0d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com