feat!: remove x/gov/migrations/v046.Migrate_V046_6_To_V046_7 #14422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Dec 26, 2022
CHANGELOG.md
Outdated
| @@ -41,6 +41,10 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| * (x/gov) [#14347](https://github.com/cosmos/cosmos-sdk/pull/14347) Support `v1.Proposal` message in `v1beta1.Proposal.Content`. | |||
|
|
|||
| ### API Breaking | |||
|
|
|||
| * (x/gov) Remove `Migrate_V046_6_To_V046_7` function which shouldn't be used for chains which already migrated to 0.46. | |||
There was a problem hiding this comment.
Don't think it warrants a changelog, actually, because people on 0.46.7 won't see it anyway.
There was a problem hiding this comment.
I don't mind removing it, but technically it's a diff between 0.46.7 and 0.46.8. Any other opinion?
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #14335 (comment)
If you are already on 0.46 and you have ongoing proposal with voting during the 0.46.7 migration then the following line will fail:
https://github.com/cosmos/cosmos-sdk/blob/v0.46.7/x/gov/migrations/v046/store.go#L54
If you are not on v0.46 and planning to migrate to v0.46, then the module migration will update the votes anyway.
We don't need to expose that function.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change