Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve baseapp event emission #14356

Merged
merged 9 commits into from
Dec 19, 2022
Merged

fix: improve baseapp event emission #14356

merged 9 commits into from
Dec 19, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #14295

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner December 19, 2022 17:40
@julienrbrt julienrbrt marked this pull request as draft December 19, 2022 17:40
@julienrbrt julienrbrt marked this pull request as ready for review December 19, 2022 17:41
@julienrbrt julienrbrt mentioned this pull request Dec 19, 2022
Closed
19 tasks
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 19, 2022
@alexanderbez
Copy link
Contributor

I was thinking it could prove to be useful in tests and maybe by clients to have a method on Event like HasAttribute or HasAttributeKey or something, then we could pass "module" to that.

julienrbrt
julienrbrt commented Dec 19, 2022
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julienrbrt
Copy link
Member Author

I was thinking it could prove to be useful in tests and maybe by clients to have a method on Event like HasAttribute or HasAttributeKey or something, then we could pass "module" to that.

Added!

@julienrbrt julienrbrt changed the title fix: do not emit module name if modules already do fix: improve baseapp event emission Dec 19, 2022
@julienrbrt julienrbrt enabled auto-merge (squash) December 19, 2022 21:51
alexanderbez
alexanderbez approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienrbrt julienrbrt merged commit 351916e into main Dec 19, 2022
@julienrbrt julienrbrt deleted the julien/event-emit branch December 19, 2022 22:45
@mergify mergify bot mentioned this pull request Dec 19, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 19, 2022
@julienrbrt @mergify
fix: improve baseapp event emission (#14356)
68c356b 
(cherry picked from commit 351916e)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Dec 19, 2022
@mergify @julienrbrt
fix: improve baseapp event emission (backport #14356) (#14362)
5ed4075 
Co-authored-by: Julien Robert <[email protected]>
0Tech added a commit to Finschia/finschia-sdk that referenced this pull request Aug 10, 2023
@0Tech @julienrbrt
fix: improve baseapp event emission (backport cosmos/cosmos-sdk#14356) (
eed9bb8 
#1075)

* fix: improve baseapp event emission (#14356)

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 24, 2023
@0Tech @julienrbrt
fix: improve baseapp event emission (backport cosmos/cosmos-sdk#14356) (
9e99ab5 
Finschia#1075)

* fix: improve baseapp event emission (#14356)

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
0Tech added a commit to Finschia/finschia-sdk that referenced this pull request Aug 24, 2023
@0Tech @julienrbrt
fix: improve baseapp event emission (backport #1075) (#1091)
0538b80 
* fix: improve baseapp event emission (backport cosmos/cosmos-sdk#14356) (#1075)

* fix: improve baseapp event emission (#14356)

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <[email protected]>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner automatically assigned from cosmos/sdk-core-dev

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner automatically assigned from cosmos/sdk-core-dev

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event attribute value for sdk.AttributeKeyModule is incorrectly determined with ibc-go Msg types
2 participants
@julienrbrt @alexanderbez