Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multi platform go build in docker push workflow #13993

Merged
merged 8 commits into from
Nov 27, 2022

Conversation

rnbguy
Copy link
Contributor

@rnbguy rnbguy commented Nov 23, 2022

Description

Closes: #13989

  • GOOS=$TARGETOS GOARCH=$TARGETARCH in Dockerfile to fix multi-platform build. [Ref]
  • Sets up docker build and push for ghcr.io
  • Replaces old logic to parse version tag with docker/metadata-action
Event Ref Docker Tags
push refs/heads/main latest
push tag refs/tags/v0.45.8 v0.45.8, latest-0.45
push tag refs/tags/v0.46.7 v0.46.7, latest-0.46

Example container package on my fork - https://github.com/rnbguy/cosmos-sdk/pkgs/container/cosmos-sdk

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rnbguy rnbguy requested a review from a team as a code owner November 23, 2022 18:18
@rnbguy rnbguy changed the title Fix go build for docker image Fix multi platform go build in docker build workflow Nov 23, 2022
@rnbguy rnbguy changed the title Fix multi platform go build in docker build workflow Fix multi platform go build in docker push workflow Nov 23, 2022
@julienrbrt julienrbrt changed the title Fix multi platform go build in docker push workflow fix: fix multi platform go build in docker push workflow Nov 23, 2022
Dockerfile Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) November 27, 2022 12:59
@tac0turtle tac0turtle merged commit 45cc1b0 into cosmos:main Nov 27, 2022
@rnbguy
Copy link
Contributor Author

rnbguy commented Nov 27, 2022

@tac0turtle I see the build is failed. Also, the cosmos-sdk package page is giving 500. Can you check if this repo has the correct access for the package?

@tac0turtle
Copy link
Member

Yup will, could be the package isnt created so its having issues create it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch64 images are labeled as amd64 on dockerhub
3 participants