-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tx encode and decode endpoints for amino txs #13882
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13882 +/- ##
==========================================
+ Coverage 56.25% 56.32% +0.06%
==========================================
Files 667 673 +6
Lines 56576 56913 +337
==========================================
+ Hits 31829 32055 +226
- Misses 22165 22254 +89
- Partials 2582 2604 +22
|
…ita/add-amino-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should unmarshal amino_json
first, then marshal it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, could we get a changelog and then we should add it to a client section in docs if we have a section .
added changelog, the client docs should go here |
…ita/add-amino-endpoints
…ita/add-amino-endpoints
…ita/add-amino-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…ita/add-amino-endpoints
…ita/add-amino-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still some confusion between amino binary and amino JSON in this PR. @likhita-809 I'll let you address the comments, but ping me on Slack if you have questions
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
…os/cosmos-sdk into likhita/add-amino-endpoints
…ita/add-amino-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* add proto changes * make proto-gen * wip: adds tests * wip: tests * remove consoles * wip: fix something * fix: encode amino tests * add decode amino tests * wip: address requested changes * update proto inline docs * address review comments Co-authored-by: Amaury M <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: atheeshp <[email protected]> (cherry picked from commit e260fc1)
…) (#14009) * feat: Add tx encode and decode endpoints for amino txs (#13882) * add proto changes * make proto-gen * wip: adds tests * wip: tests * remove consoles * wip: fix something * fix: encode amino tests * add decode amino tests * wip: address requested changes * update proto inline docs * address review comments Co-authored-by: Amaury M <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: atheeshp <[email protected]> (cherry picked from commit e260fc1) * fix changelog Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #10856
ref: #13085
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change