-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR-038 go-plugin system #13472
ADR-038 go-plugin system #13472
Conversation
The in-process streaming service is still supported by calling |
Yes. cosmos-sdk/baseapp/streaming.go Lines 104 to 108 in 9ccf4fe
|
Awesome! Looking forward to reviewing this! |
I'd like to have this blocked until #13473 gets sufficiently reviewed and approved 👍 |
|
My apologies. I accidentally closed this while trying to comment. |
Overall love the improvements. Thinking out loud: should we remove the file service already present in the repo? Can be in a subsequent pr. |
app.cms.AddListeners(key, lis) | ||
} | ||
// register the StreamingService within the BaseApp | ||
// BaseApp will pass BeginBlock, DeliverTx, and EndBlock requests and responses to the streaming services to update their ABCI context | ||
app.abciListeners = append(app.abciListeners, s) | ||
app.abciListener = s.ABCIListener | ||
app.stopNodeOnStreamingErr = s.StopNodeOnErr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It don't support registering multiple StreamingService
s with this implementation?
I am closing this as the work in this PR is stale. Work has moved to #14207. |
For #10096
replaces #11691
This is an extension and refactor of the existing ADR-038 streaming service work to introduce a plugin system over gRPC to the SDK and load streaming services using the hashicorp/go-plugin system rather the approach taken in #11691 (which uses Go's built in Plugins API).
The plugin system introduced here is meant to be extensible, so that if other components/features of the SDK wish to be included as plugins in the future they can write plugins with minimal effort by defining an interface and a gRPC message protocol and leveraging the built in plugin system.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change