Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request puts the Simulate and Broadcast transaction closer to parity. When a transaction fails on-chain it will anyways return the gas used. Same as developed in this PR to return the gas used but in order to avoid breaking changes I have decided to add a new field named mode which by default it behaves as know until now, but when the mode is set to GAS_USED it will return also the amount of gas used with the status code 200 even if the simulation fails.
Author Checklist
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
I have...
!
in the type prefix if API or client breaking change