Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change id to use uint64 in AccountAddressByID #13411

Merged
merged 3 commits into from
Sep 28, 2022
Merged

chore: change id to use uint64 in AccountAddressByID #13411

merged 3 commits into from
Sep 28, 2022

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #13410

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review September 28, 2022 07:10
@atheeshp atheeshp requested a review from a team as a code owner September 28, 2022 07:10
@codecov
Copy link

codecov bot commented Sep 28, 2022 •
edited
Loading

Codecov Report

Merging #13411 (bd2b6ca) into main (4fe7797) will decrease coverage by 1.96%.
The diff coverage is 28.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13411      +/-   ##
==========================================
- Coverage   55.87%   53.91%   -1.97%     
==========================================
  Files         646      641       -5     
  Lines       54895    55031     +136     
==========================================
- Hits        30675    29668    -1007     
- Misses      21762    22982    +1220     
+ Partials     2458     2381      -77
Impacted Files Coverage Δ
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 67.92% <ø> (-0.60%) ⬇️
client/broadcast.go 54.54% <ø> (+2.99%) ⬆️
client/cmd.go 57.73% <ø> (ø)
client/config/toml.go 55.55% <ø> (ø)
client/context.go 54.49% <ø> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
... and 257 more

@atheeshp atheeshp changed the title fix: change id to use uint64 in AccountAddressByID Chore: change id to use uint64 in AccountAddressByID Sep 28, 2022
@atheeshp atheeshp changed the title Chore: change id to use uint64 in AccountAddressByID chore: change id to use uint64 in AccountAddressByID Sep 28, 2022
tac0turtle
tac0turtle approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez alexanderbez merged commit 3d0e214 into main Sep 28, 2022
@alexanderbez alexanderbez deleted the ap/fix-account-id branch September 28, 2022 16:42
@amaury1093
Copy link
Contributor

amaury1093 commented Oct 5, 2022 •
edited
Loading

We unfortunately need to revert this PR. The int64 version was released in v0.46.2, so it's out there. If we include this PR in v0.47, then it will be a protobuf-breaking change (see the failing Github action), which should come with a proto version bump.

@amaury1093 amaury1093 mentioned this pull request Oct 5, 2022
Merged
19 tasks
@alexanderbez
Copy link
Contributor

RIP

amaury1093 added a commit that referenced this pull request Oct 6, 2022
@amaury1093
Revert "chore: change id to use uint64 in AccountAddressByID (#13411)"
c864bc7 
This reverts commit 3d0e214.
@amaury1093 amaury1093 mentioned this pull request Oct 6, 2022
Merged
19 tasks
amaury1093 added a commit that referenced this pull request Oct 6, 2022
@amaury1093 @julienrbrt
refactor: Improve and clarify API around AccountAddressById (#13460)
90bd316 
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

Co-authored-by: Julien Robert <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 6, 2022
@amaury1093 @mergify
refactor: Improve and clarify API around AccountAddressById (#13460)
10a4f05 
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 90bd316)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	api/cosmos/distribution/v1beta1/query_grpc.pb.go
#	api/cosmos/group/v1/types.pulsar.go
#	proto/cosmos/auth/v1beta1/query.proto
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/distribution/types/query.pb.go
amaury1093 added a commit that referenced this pull request Oct 6, 2022
@mergify @amaury1093
refactor: Improve and clarify API around AccountAddressById (backport
982b891 
#13460) (#13461)

* refactor: Improve and clarify API around `AccountAddressById`  (#13460)

* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 90bd316)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	api/cosmos/distribution/v1beta1/query_grpc.pb.go
#	api/cosmos/group/v1/types.pulsar.go
#	proto/cosmos/auth/v1beta1/query.proto
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/distribution/types/query.pb.go

* fix conflicts

* changelog

Co-authored-by: Amaury <[email protected]>
@aaronc aaronc mentioned this pull request Oct 26, 2022
Merged
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @amaury1093 @JeancarloBarrios
refactor: Improve and clarify API around AccountAddressById (backport
e9653b0 
cosmos#13460) (cosmos#13461)

* refactor: Improve and clarify API around `AccountAddressById`  (cosmos#13460)

* Revert "chore: change id to use uint64 in `AccountAddressByID` (cosmos#13411)"

This reverts commit 3d0e214.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <[email protected]>

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 90bd316)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	api/cosmos/distribution/v1beta1/query_grpc.pb.go
#	api/cosmos/group/v1/types.pulsar.go
#	proto/cosmos/auth/v1beta1/query.proto
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/distribution/types/query.pb.go

* fix conflicts

* changelog

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@likhita-809 likhita-809 Awaiting requested review from likhita-809

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@anilcse anilcse Awaiting requested review from anilcse

Assignees
No one assigned
Labels
C:CLI C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account-id type used as int64 instead of uint64
5 participants
@atheeshp @amaury1093 @alexanderbez @tac0turtle @julienrbrt