Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix golangci-lint issue #13300

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix: Fix golangci-lint issue #13300

merged 1 commit into from
Sep 15, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
Copy link
Member

Still curious why this happened, https://github.com/cosmos/cosmos-sdk/actions/runs/3055286433/jobs/4928174136.

@julienrbrt julienrbrt marked this pull request as ready for review September 15, 2022 08:18
@julienrbrt julienrbrt requested a review from a team as a code owner September 15, 2022 08:18
@julienrbrt julienrbrt enabled auto-merge (squash) September 15, 2022 08:18
@julienrbrt julienrbrt enabled auto-merge (squash) September 15, 2022 08:18
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #13300 (25714de) into main (ae21d8c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13300      +/-   ##
==========================================
- Coverage   55.01%   54.96%   -0.05%     
==========================================
  Files         649      648       -1     
  Lines       55404    55346      -58     
==========================================
- Hits        30479    30423      -56     
  Misses      22476    22476              
+ Partials     2449     2447       -2     
Impacted Files Coverage Δ
server/grpc/gogoreflection/fix_registration.go 31.81% <0.00%> (ø)
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) ⬇️
client/v2/cli/query.go
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants