Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tx hash to query output in LCD #1317

Merged
merged 5 commits into from
Jun 21, 2018
Merged

Added tx hash to query output in LCD #1317

merged 5 commits into from
Jun 21, 2018

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented Jun 21, 2018 •
edited
Loading

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

closes #318

@faboweb faboweb requested a review from ebuchman as a code owner June 21, 2018 02:49
@faboweb faboweb mentioned this pull request Jun 21, 2018
Closed
3 tasks
@codecov
Copy link

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@81c773c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1317   +/-   ##
==========================================
  Coverage           ?   65.28%           
==========================================
  Files              ?      102           
  Lines              ?     5533           
  Branches           ?        0           
==========================================
  Hits               ?     3612           
  Misses             ?     1712           
  Partials           ?      209

@faboweb
Copy link
Contributor Author

faboweb commented Jun 21, 2018

@nylira this should go in an own issue

cwgoes
cwgoes approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 4884747 into develop Jun 21, 2018
@cwgoes cwgoes deleted the fabo/add-hash-to-tx-output-in-lcd branch June 21, 2018 17:22
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@faboweb
Merge PR #1317: Added tx hash to query output in LCD
ccb385c 
* added tx hash
* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide TX uids
2 participants
@faboweb @cwgoes