-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: printf for Record protobuf #13145
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13145 +/- ##
==========================================
- Coverage 55.87% 53.71% -2.17%
==========================================
Files 646 645 -1
Lines 54895 55258 +363
==========================================
- Hits 30675 29681 -994
- Misses 21762 23200 +1438
+ Partials 2458 2377 -81
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you touch on why this fixes the issue at hand? Gogoproto issue?
I've updated the issue with some more details #11368 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting issue
Description
Closes: #11368
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change