Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky appconfig test #12891

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: flaky appconfig test #12891

merged 1 commit into from
Aug 10, 2022

Conversation

kocubinski
Copy link
Member

Description

Closes: #12883

depinject dependency ordering is not deterministic where there are multiple tree traversal solutions satisfying the graph, AFAIK it's not a design goal though.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner August 10, 2022 14:07
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #12891 (83b85fb) into main (50cec67) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12891      +/-   ##
==========================================
+ Coverage   56.20%   56.23%   +0.02%     
==========================================
  Files         650      647       -3     
  Lines       55072    55036      -36     
==========================================
- Hits        30954    30950       -4     
+ Misses      21621    21589      -32     
  Partials     2497     2497              
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/bytes.go
core/appconfig/config.go 74.02% <0.00%> (ø)
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

@julienrbrt julienrbrt merged commit 461cfd6 into main Aug 10, 2022
@julienrbrt julienrbrt deleted the kocubinski/fix-appconfig-test branch August 10, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: TestCompose
4 participants