WIP: Parallelize Invariants #12775
Closed
WIP: Parallelize Invariants #12775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| n := len(invarRoutes) | ||
| var ( | ||
| logger = k.Logger(ctx) | ||
| start = time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time
|
I think it's only the can-withdraw to be super slow, all the other invariants get completed quite quickly |
This is my understanding as well. #9876 this encapsulates that's |
peterbourgon
reviewed
Aug 1, 2022
Comment on lines
+102
to
105
| if err := eg.Wait(); err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err := eg.Wait(); err != nil { | |
| panic(err) | |
| } | |
| } | |
| } | |
| if err := eg.Wait(); err != nil { | |
| panic(err) | |
| } |
|
closing this as @odeke-em and team are working on fixing the performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to test this, and maybe this is too dumb but worth trying at least.