feat: allow custom authority and inflation function when using app-wiring #12660
Conversation
github-actions
bot
added
C:x/crisis
C:x/distribution
julienrbrt
force-pushed
the
julien/app-wiring-func
branch
from
4db80ad to
3c9dce0
Compare
x/mint/module.go
Outdated
| Config *modulev1.Module | ||
| Key *store.KVStoreKey | ||
| Cdc codec.Codec | ||
| Authority types.MintAuthority `optional:"true"` |
There was a problem hiding this comment.
slightly lost where this gets set? I thought you would need to modify protobuf config of each module? (https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/mint/module/v1/module.proto#L13)
There was a problem hiding this comment.
We set it in the app.go in depinject.Supply (see comments). This is because it could be just an address or we want to get a module address, so I don't think it can be in the app_config / app.yaml.
There was a problem hiding this comment.
makes sense. still trying to wrap my head around some of DI
x/crisis/types/authority.go
Outdated
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| type CrisisAuthority sdk.AccAddress |
There was a problem hiding this comment.
Why is there a need for a dedicated type (alias)?
There was a problem hiding this comment.
If we named them all Authority, there would be a name collision.
Let me try another implementation to see which one you prefer
There was a problem hiding this comment.
I've simplified it in d623377. What do you think?
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change