feat: Make a Denoms method on sdk.Coins #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Jul 19, 2022
amaury1093
reviewed
Jul 19, 2022
ratankaliani
commented
Jul 19, 2022
| @@ -42,6 +42,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (cli) [#12028](https://github.com/cosmos/cosmos-sdk/pull/12028) Add the `tendermint key-migrate` to perform Tendermint v0.35 DB key migration. | |||
| * (query) [#12253](https://github.com/cosmos/cosmos-sdk/pull/12253) Add `GenericFilteredPaginate` to the `query` package to improve UX. | |||
| * (telemetry) [#12405](https://github.com/cosmos/cosmos-sdk/pull/12405) Add _query_ calls metric to telemetry. | |||
| * (sdk.Coins) [#12627](https://github.com/cosmos/cosmos-sdk/pull/12627) Make a Denoms method on sdk.Coins. | |||
There was a problem hiding this comment.
linked! my bad
Codecov Report
@@ Coverage Diff @@
## main #12627 +/- ##
==========================================
- Coverage 65.24% 65.20% -0.04%
==========================================
Files 697 693 -4
Lines 72075 71822 -253
==========================================
- Hits 47026 46834 -192
+ Misses 22406 22355 -51
+ Partials 2643 2633 -10
|
tac0turtle
approved these changes
Jul 19, 2022
tac0turtle
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12538
Adds a Denoms method to sdk.Coins to return a string array of all denoms in Coins & adds simple testing on Denoms.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change