Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dependency on simapp from client tests #12545

Merged
merged 7 commits into from
Jul 12, 2022

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Jul 12, 2022

Description

Ref: #12544

Removes direct dependencies on simapp but does not remove transitive dependency through the use of testutil (yet).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Jul 12, 2022
@kocubinski kocubinski changed the title Kocubinski/refactor client simapp refactor: remove dependency on simapp from client tests Jul 12, 2022
@kocubinski kocubinski marked this pull request as ready for review July 12, 2022 21:15
@kocubinski kocubinski requested a review from a team as a code owner July 12, 2022 21:15
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kocubinski kocubinski merged commit 203d563 into main Jul 12, 2022
@kocubinski kocubinski deleted the kocubinski/refactor-client-simapp branch July 12, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants