Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tmservice times out after 30min in test-race (00) #12482

Closed
wants to merge 4 commits into from

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 7, 2022

Description

WIP as trying to reproduce different possible fixes against the CI.

Closes: #12420


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #12482 (f25f7d8) into main (18da0e9) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f25f7d8 differs from pull request most recent head 1bbaea2. Consider uploading reports for the commit 1bbaea2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12482      +/-   ##
==========================================
+ Coverage   65.59%   65.62%   +0.02%     
==========================================
  Files         685      685              
  Lines       71635    71635              
==========================================
+ Hits        46990    47008      +18     
+ Misses      21999    21980      -19     
- Partials     2646     2647       +1     
Impacted Files Coverage Δ
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

mergify bot pushed a commit that referenced this pull request Jul 11, 2022
…2513)

## Description

This PR disables the tendermint query server integration test so that our CI does not keep timing out.
It will be re-enabled with a fix in #12482



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@julienrbrt
Copy link
Member Author

@kocubinski fixed it with #12676 ❤️

Closing this :)

@julienrbrt julienrbrt closed this Jul 23, 2022
@julienrbrt julienrbrt deleted the julien/fix-test-race-00 branch July 23, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmservice times out after 30min in test-race (00)
1 participant