Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(x/feegrant): use coins instead of tokens #12444

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 5, 2022

Description

Closes: #12422


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title docs: use coins instead of tokens x/feegrant docs(x/feegrant): use coins instead of tokens Jul 5, 2022
@atheeshp atheeshp marked this pull request as ready for review July 5, 2022 07:11
@atheeshp atheeshp requested a review from a team as a code owner July 5, 2022 07:11
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #12444 (be3bcaa) into main (ff3947a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12444      +/-   ##
==========================================
+ Coverage   65.63%   65.65%   +0.02%     
==========================================
  Files         683      683              
  Lines       71549    71549              
==========================================
+ Hits        46959    46978      +19     
+ Misses      21948    21928      -20     
- Partials     2642     2643       +1     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jul 5, 2022
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 5, 2022
@mergify mergify bot merged commit c3314ea into main Jul 5, 2022
@mergify mergify bot deleted the ap/feegrant-docs branch July 5, 2022 14:19
mergify bot pushed a commit that referenced this pull request Jul 5, 2022
## Description

Closes: #12422

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit c3314ea)

# Conflicts:
#	api/cosmos/feegrant/v1beta1/feegrant.pulsar.go
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:x/feegrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize use of coins and tokens in feegrant Concepts documentation
3 participants