Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple x/feegrant and simapp #12388

Merged
merged 12 commits into from
Jun 30, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Ports #12366 to main
cc @facundomedica


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #12388 (d5c45f5) into main (99b21ab) will decrease coverage by 0.15%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12388      +/-   ##
==========================================
- Coverage   65.83%   65.67%   -0.16%     
==========================================
  Files         677      676       -1     
  Lines       71496    71429      -67     
==========================================
- Hits        47070    46912     -158     
- Misses      21783    21877      +94     
+ Partials     2643     2640       -3     
Impacted Files Coverage Δ
x/feegrant/module/module.go 44.94% <0.00%> (-11.24%) ⬇️
x/feegrant/client/testutil/suite.go 88.36% <100.00%> (-11.30%) ⬇️
x/feegrant/simulation/operations.go 83.63% <100.00%> (ø)
core/appconfig/config.go

@julienrbrt julienrbrt merged commit a32349d into main Jun 30, 2022
@julienrbrt julienrbrt deleted the facu/decouple-feegrant-simapp branch June 30, 2022 11:19
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* progress

* simapp out

* add files

* Update x/feegrant/simulation/operations_test.go

Co-authored-by: atheeshp <[email protected]>

* updates comments

* implement feedback

* apply suggestions

Co-authored-by: Facundo Medica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants