Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple x/group from simapp #12277

Merged
merged 10 commits into from
Jun 17, 2022
Merged

feat: decouple x/group from simapp #12277

merged 10 commits into from
Jun 17, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12024

decouple x/group from simapp


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 changed the title Likhita/decouple group feat: decouple `x/group Jun 16, 2022
@likhita-809 likhita-809 changed the title feat: decouple `x/group feat: decouple x/group from simapp Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #12277 (859d3f7) into main (7623603) will decrease coverage by 0.03%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12277      +/-   ##
==========================================
- Coverage   66.16%   66.12%   -0.04%     
==========================================
  Files         675      675              
  Lines       71272    71273       +1     
==========================================
- Hits        47156    47129      -27     
- Misses      21469    21499      +30     
+ Partials     2647     2645       -2     
Impacted Files Coverage Δ
x/group/module/module.go 48.27% <0.00%> (-12.19%) ⬇️
x/group/simulation/operations.go 68.08% <100.00%> (ø)
x/group/keeper/invariants.go 42.64% <0.00%> (-10.30%) ⬇️
x/distribution/simulation/operations.go 80.43% <0.00%> (-9.79%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/group/keeper/keeper.go 57.38% <0.00%> (+2.95%) ⬆️

@likhita-809 likhita-809 marked this pull request as ready for review June 17, 2022 11:42
@likhita-809 likhita-809 requested a review from a team as a code owner June 17, 2022 11:42
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 17, 2022
@julienrbrt julienrbrt merged commit 5d3fd85 into main Jun 17, 2022
@julienrbrt julienrbrt deleted the likhita/decouple-group branch June 17, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/groups to use app wiring
2 participants