-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate x/crisis use app wiring #12270
Merged
julienrbrt
merged 47 commits into
epic/app-wiring
from
JeancarloBarrios/migrate_crisis_use_app_wiring
Jun 29, 2022
Merged
feat: migrate x/crisis use app wiring #12270
julienrbrt
merged 47 commits into
epic/app-wiring
from
JeancarloBarrios/migrate_crisis_use_app_wiring
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeancarloBarrios
changed the title
Jeancarlo barrios/migrate crisis use app wiring
feat: migrate x/crisis use app wiring
Jun 15, 2022
3 tasks
The error log for a single test is as follow
|
julienrbrt
reviewed
Jun 17, 2022
Co-authored-by: Julien Robert <[email protected]>
…s://github.com/cosmos/cosmos-sdk into JeancarloBarrios/migrate_crisis_use_app_wiring
19 tasks
Co-authored-by: Julien Robert <[email protected]>
…s://github.com/cosmos/cosmos-sdk into JeancarloBarrios/migrate_crisis_use_app_wiring
julienrbrt
reviewed
Jun 29, 2022
julienrbrt
reviewed
Jun 29, 2022
julienrbrt
reviewed
Jun 29, 2022
julienrbrt
approved these changes
Jun 29, 2022
JeancarloBarrios
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jun 29, 2022
julienrbrt
removed
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jun 29, 2022
julienrbrt
force-pushed
the
JeancarloBarrios/migrate_crisis_use_app_wiring
branch
from
June 29, 2022 14:13
61c2f5a
to
1d4f9fe
Compare
Codecov Report
@@ Coverage Diff @@
## epic/app-wiring #12270 +/- ##
===================================================
- Coverage 65.67% 65.63% -0.04%
===================================================
Files 676 676
Lines 71429 71434 +5
===================================================
- Hits 46911 46889 -22
- Misses 21878 21906 +28
+ Partials 2640 2639 -1
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App Wiring for Crisis
Implements: 1/3 of #12194
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change