Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple x/capability from simapp #12256

Merged
merged 10 commits into from
Jun 16, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 14, 2022

Description

Closes: #12069


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review June 16, 2022 10:11
@julienrbrt julienrbrt requested a review from a team as a code owner June 16, 2022 10:11
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #12256 (3d5e773) into main (8fa2fab) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12256      +/-   ##
==========================================
+ Coverage   66.07%   66.16%   +0.08%     
==========================================
  Files         675      675              
  Lines       71280    71267      -13     
==========================================
+ Hits        47099    47152      +53     
+ Misses      21538    21468      -70     
- Partials     2643     2647       +4     
Impacted Files Coverage Δ
simapp/app.go 77.08% <100.00%> (+4.35%) ⬆️
x/capability/module.go 59.49% <100.00%> (-9.84%) ⬇️
baseapp/baseapp.go 78.45% <0.00%> (-0.91%) ⬇️
x/group/keeper/keeper.go 54.43% <0.00%> (-0.43%) ⬇️
x/params/module.go 57.14% <0.00%> (+1.58%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/evidence/module.go 41.46% <0.00%> (+2.43%) ⬆️
x/mint/module.go 50.68% <0.00%> (+2.73%) ⬆️
x/distribution/simulation/operations.go 90.21% <0.00%> (+9.78%) ⬆️
... and 3 more

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 16, 2022
@julienrbrt julienrbrt force-pushed the julien/capability-decouple-simapp branch from 0730a10 to 3d5e773 Compare June 16, 2022 22:36
@julienrbrt julienrbrt merged commit aba9bdc into main Jun 16, 2022
@julienrbrt julienrbrt deleted the julien/capability-decouple-simapp branch June 16, 2022 22:47
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/capability C:x/nft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/capability to use app wiring
2 participants