Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Buildjet pr #12231

Merged
merged 25 commits into from
Jun 16, 2022
Merged

chore: Buildjet pr #12231

merged 25 commits into from
Jun 16, 2022

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Jun 12, 2022

Description

double the compute of our main runners,

@tac0turtle
Copy link
Member Author

replaces #12219, thanks for the PR @faddat

@faddat
Copy link
Contributor

faddat commented Jun 12, 2022

uh-oh, both yours and mine don't seem to trigger.

hmmmmmmmmm

Sorry, I am not sure how to help on this further-- for whatever reason, the notional-labs/cosmos-sdk repo works.

I am actually really enthusiastic about gitlab and have made but not used one for Juno.

the tl;dr is that gitlab wrote an amazing runner in Go and I've never failed to get it to work in any mode.

I do fail frequently with the github actions runner, though. I built an on-site kube cluster for actions and though I did get it working, honestly it was bad.

Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works-- now we've got to hope it'll get picked up by buildjet :)

@tac0turtle tac0turtle changed the title Buildjet pr chore: Buildjet pr Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #12231 (5eb714a) into main (6a3d10b) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 5eb714a differs from pull request most recent head e280722. Consider uploading reports for the commit e280722 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12231      +/-   ##
==========================================
+ Coverage   66.07%   66.11%   +0.03%     
==========================================
  Files         675      675              
  Lines       71276    71275       -1     
==========================================
+ Hits        47096    47122      +26     
+ Misses      21537    21508      -29     
- Partials     2643     2645       +2     
Impacted Files Coverage Δ
simapp/app.go 72.72% <ø> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/params/keeper/querier.go 4.00% <0.00%> (+4.00%) ⬆️
x/distribution/simulation/operations.go 90.21% <0.00%> (+9.78%) ⬆️
x/params/module.go 69.35% <0.00%> (+13.79%) ⬆️

@tac0turtle tac0turtle marked this pull request as ready for review June 15, 2022 17:15
@tac0turtle tac0turtle requested a review from a team as a code owner June 15, 2022 17:15
simapp/app.go Outdated Show resolved Hide resolved
Co-authored-by: Julien Robert <[email protected]>
@julienrbrt julienrbrt linked an issue Jun 15, 2022 that may be closed by this pull request
4 tasks
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 15, 2022
@tac0turtle tac0turtle merged commit c2d4db3 into main Jun 16, 2022
@tac0turtle tac0turtle deleted the buildjet-pr branch June 16, 2022 09:32
@faddat
Copy link
Contributor

faddat commented Jun 22, 2022

@marbar3778 did you find this to go faster?

@tac0turtle
Copy link
Member Author

I haven't been following. I think @julienrbrt would know better

@julienrbrt
Copy link
Member

Yes it's drastically faster. However I haven't been able to really enjoy it as our CI still fails randomly and times out due to TM after 30 minutes.

When this gets fixed it will be amazing :)

Manav-Aggarwal added a commit to celestiaorg/cosmos-sdk that referenced this pull request Aug 16, 2022
@julienrbrt julienrbrt mentioned this pull request Oct 27, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI Faster
3 participants