Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staking): Fix JSON genesis migration #12140

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jun 3, 2022

Description

ref: #11880

TEST:

./build/v045_node export > old.json
./build/v046_node migrate v0.46 old.json > new.json
./build/v046_node init alice
cp new.json ~/.simapp/config/genesis.json
./build/v046_node start --mode validator

The above script panicked on the start command before this PR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:x/genutil genutil module issues C:x/staking labels Jun 3, 2022
@amaury1093 amaury1093 marked this pull request as ready for review June 3, 2022 11:16
@amaury1093 amaury1093 requested a review from a team as a code owner June 3, 2022 11:16
@amaury1093 amaury1093 mentioned this pull request Jun 3, 2022
72 tasks
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #12140 (b5236cf) into main (889dfcb) will decrease coverage by 0.03%.
The diff coverage is 76.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12140      +/-   ##
==========================================
- Coverage   66.04%   66.00%   -0.04%     
==========================================
  Files         671      672       +1     
  Lines       71055    71044      -11     
==========================================
- Hits        46927    46896      -31     
- Misses      21465    21485      +20     
  Partials     2663     2663              
Impacted Files Coverage Δ
baseapp/baseapp.go 79.27% <ø> (ø)
client/cmd.go 57.73% <0.00%> (ø)
client/grpc_query.go 30.33% <0.00%> (ø)
client/keys/add.go 63.34% <0.00%> (ø)
pruning/manager.go 95.18% <ø> (ø)
server/mock/tx.go 63.15% <ø> (ø)
server/rosetta/converter.go 56.28% <0.00%> (ø)
simapp/test_helpers.go 26.34% <0.00%> (ø)
testutil/network/network.go 62.40% <ø> (ø)
types/address.go 66.76% <ø> (ø)
... and 52 more

@amaury1093 amaury1093 added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jun 3, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit 67a04a5 into main Jun 3, 2022
@alexanderbez alexanderbez deleted the am/fix-mig-stake branch June 3, 2022 14:06
mergify bot pushed a commit that referenced this pull request Jun 3, 2022
tac0turtle pushed a commit that referenced this pull request Jun 3, 2022
gsk967 pushed a commit to vulcanize/cosmos-sdk that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:x/genutil genutil module issues C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants