Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate x/genutil to app wiring #12124

Merged
merged 9 commits into from
Jun 10, 2022
Merged

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Jun 2, 2022

Description

Closes: #12035

Needs: #12056 for TxConfig


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label Jun 2, 2022
x/genutil/module.go Outdated Show resolved Hide resolved
x/genutil/module.go Outdated Show resolved Hide resolved
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #12124 (f128a00) into main (c859589) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12124      +/-   ##
==========================================
- Coverage   66.14%   66.13%   -0.02%     
==========================================
  Files         673      672       -1     
  Lines       71013    70955      -58     
==========================================
- Hits        46973    46927      -46     
+ Misses      21402    21394       -8     
+ Partials     2638     2634       -4     
Impacted Files Coverage Δ
simapp/app.go 75.32% <ø> (-0.43%) ⬇️
x/genutil/module.go 66.66% <90.00%> (+9.09%) ⬆️
core/appconfig/config.go

@blushi blushi marked this pull request as ready for review June 10, 2022 08:14
@blushi blushi requested a review from a team as a code owner June 10, 2022 08:14
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/genutil/module.go Outdated Show resolved Hide resolved
x/genutil/module.go Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tac0turtle tac0turtle merged commit 7688ce6 into main Jun 10, 2022
@tac0turtle tac0turtle deleted the marie/12035-app-wiring-genutil branch June 10, 2022 09:56
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Add genutil module.proto and module init

* Update simapp

* Add provideDeliverTx to runtime

* Update x/genutil/module.go

* Update x/genutil/module.go

Co-authored-by: Marko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/genutil to use app wiring
4 participants