Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running a tx with --dry-run returns an error #12095

Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 31, 2022

Description

Closes: #12074


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue May 31, 2022 that may be closed by this pull request
4 tasks
@alexanderbez
Copy link
Contributor

Crushing it @julienrbrt 🚀🚀🚀

@alexanderbez alexanderbez marked this pull request as ready for review May 31, 2022 13:30
@alexanderbez alexanderbez requested a review from a team as a code owner May 31, 2022 13:30
@julienrbrt julienrbrt marked this pull request as draft May 31, 2022 13:30
@julienrbrt julienrbrt marked this pull request as ready for review May 31, 2022 14:58
@julienrbrt julienrbrt requested a review from fedekunze May 31, 2022 14:58
@julienrbrt
Copy link
Member Author

cc @fedekunze as you've been working on #11283

@julienrbrt julienrbrt force-pushed the julien/12074-running-a-tx-with-dry-run-returns-an-error branch from dd3f626 to e0293ee Compare May 31, 2022 15:01
client/tx/factory.go Outdated Show resolved Hide resolved
client/tx/factory.go Outdated Show resolved Hide resolved
julienrbrt and others added 2 commits June 1, 2022 00:35
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@tac0turtle tac0turtle added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jun 1, 2022
@alexanderbez alexanderbez merged commit b145333 into main Jun 1, 2022
@alexanderbez alexanderbez deleted the julien/12074-running-a-tx-with-dry-run-returns-an-error branch June 1, 2022 14:39
mergify bot pushed a commit that referenced this pull request Jun 1, 2022
alexanderbez pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running a tx with --dry-run returns an error
3 participants