-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running a tx with --dry-run returns an error #12095
Merged
alexanderbez
merged 9 commits into
main
from
julien/12074-running-a-tx-with-dry-run-returns-an-error
Jun 1, 2022
Merged
fix: running a tx with --dry-run returns an error #12095
alexanderbez
merged 9 commits into
main
from
julien/12074-running-a-tx-with-dry-run-returns-an-error
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Crushing it @julienrbrt 🚀🚀🚀 |
cc @fedekunze as you've been working on #11283 |
julienrbrt
force-pushed
the
julien/12074-running-a-tx-with-dry-run-returns-an-error
branch
from
May 31, 2022 15:01
dd3f626
to
e0293ee
Compare
alexanderbez
approved these changes
May 31, 2022
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
tac0turtle
approved these changes
Jun 1, 2022
tac0turtle
added
the
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
label
Jun 1, 2022
alexanderbez
deleted the
julien/12074-running-a-tx-with-dry-run-returns-an-error
branch
June 1, 2022 14:39
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
(cherry picked from commit b145333)
alexanderbez
pushed a commit
that referenced
this pull request
Jun 1, 2022
(cherry picked from commit b145333) Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12074
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change