Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update simapp dockerfiles #12052

Closed
wants to merge 4 commits into from
Closed

fix: update simapp dockerfiles #12052

wants to merge 4 commits into from

Conversation

alexanderbez
Copy link
Contributor

Description


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #12052 (7f8584c) into main (16badb1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12052   +/-   ##
=======================================
  Coverage   66.07%   66.07%           
=======================================
  Files         671      671           
  Lines       70916    70918    +2     
=======================================
+ Hits        46855    46857    +2     
+ Misses      21405    21404    -1     
- Partials     2656     2657    +1     
Impacted Files Coverage Δ
baseapp/abci.go 64.17% <100.00%> (+0.12%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/group/keeper/keeper.go 54.85% <0.00%> (+0.42%) ⬆️

@alexanderbez
Copy link
Contributor Author

Not sure about the following error but it seems related to the new CI caching stuff...

@kocubinski
Copy link
Member

Possible related to actions/runner#449? I am impacted too on #12051 with your changes merged in

@alexanderbez alexanderbez deleted the bez/fix-liveness branch May 26, 2022 19:41
kocubinski added a commit that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants