Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store audit #11987

Merged
merged 6 commits into from
May 18, 2022
Merged

chore: store audit #11987

merged 6 commits into from
May 18, 2022

Conversation

blushi
Copy link
Contributor

@blushi blushi commented May 18, 2022

Description

Ref: #11362


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@blushi blushi marked this pull request as ready for review May 18, 2022 13:57
@blushi blushi requested a review from a team as a code owner May 18, 2022 13:57
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #11987 (877c552) into main (0fa90ad) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11987      +/-   ##
==========================================
+ Coverage   65.94%   66.02%   +0.07%     
==========================================
  Files         677      677              
  Lines       71341    71341              
==========================================
+ Hits        47047    47103      +56     
+ Misses      21610    21551      -59     
- Partials     2684     2687       +3     
Impacted Files Coverage Δ
store/cachekv/memiterator.go 83.33% <ø> (ø)
store/cachekv/store.go 78.94% <ø> (ø)
store/iavl/store.go 67.31% <ø> (ø)
store/streaming/file/service.go 4.09% <ø> (ø)
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️
store/streaming/constructor.go 74.32% <0.00%> (+50.00%) ⬆️

@mergify mergify bot merged commit b647802 into main May 18, 2022
@mergify mergify bot deleted the marie/11362-store branch May 18, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants