-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: move x/staking Init/Export genesis to keeper #11866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Looking forward to so much public API surface decreasing from these keepers
@alexanderbez I think we also need to move the related genesis tests to keeper and we need to fix the failing tests because of staking imports in other modules. |
Codecov Report
@@ Coverage Diff @@
## main #11866 +/- ##
==========================================
- Coverage 66.05% 66.02% -0.04%
==========================================
Files 705 671 -34
Lines 73614 70718 -2896
==========================================
- Hits 48625 46689 -1936
+ Misses 22051 21359 -692
+ Partials 2938 2670 -268
|
Description
Move
InitGenesis
andExportGenesis
to theKeeper
type forx/staking
as they had no business being separate functions outside the keeper type.cc @ValarDragon
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change