feat: implement ABCI Query via gRPC

[alexanderbez]

Description

• Add a new ABCIQuery gRPC query to the Tendermint gRPC Service
• Update the queryServer to now accept a abciQueryFn that'll proxy the ABCI query request to the app
• Minor cleanup

replaces: #11017
ref: #11012

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

@colin-axner @charleenfei, could you let me know if this addresses/closes #7036 please?

[tac0turtle]

could you let me know if this addresses/closes #7036 please?

this is a short term fix, ideally we can add this natively into grpc headers, this way relayers can make normal requests and get headers instead of using this endpoint

[alexanderbez]

could you let me know if this addresses/closes #7036 please?

this is a short term fix, ideally we can add this natively into grpc headers, this way relayers can make normal requests and get headers instead of using this endpoint

Yeah there is an issue @aaronc created on that. We'll keep the issue open then but we should still get this in for IBC relayer UX.

[amaury1093]

Do people want this in v0.46? It's an API-breaking change, which requires changing your app.go, which I'd like to avoid

[alexanderbez]

Do people want this in v0.46? It's an API-breaking change, which requires changing your app.go, which I'd like to avoid

Would be really nice. I think chains want this, as it's a "nice-to-have". But it is Go API breaking, so technically we should not do it.

[jackzampolin]

I just want to pipe up in favor of including it in the 0.46 release. Its a significant improvement for clients and especially with IBC queries there are more usecases for this endpoint. We should def include this in the release with a small disclaimer.

[tac0turtle]

I just want to pipe up in favor of including it in the 0.46 release. Its a significant improvement for clients and especially with IBC queries there are more usecases for this endpoint. We should def include this in the release with a small disclaimer.

we agreed to backport as well. We agreed that the feature is well worth it

[alexanderbez]

Ok, I'm going to merge this and backport it then.