refactor(x/auth/middleware)!: tx middleware to support pluggable feemarket module

CHANGELOG.md

@@ -140,6 +140,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/authz) [\#10447](https://github.com/cosmos/cosmos-sdk/pull/10447) authz `NewGrant` takes a new argument: block time, to correctly validate expire time.
 * [\#10961](https://github.com/cosmos/cosmos-sdk/pull/10961) Support third-party modules to add extension snapshots to state-sync.
 * [\#11274](https://github.com/cosmos/cosmos-sdk/pull/11274) `types/errors.New` now is an alias for `types/errors.Register` and should only be used in initialization code.
+* (ante) [#11413](https://github.com/cosmos/cosmos-sdk/pull/11413) Refactor tx middleware to support pluggable feemarket module. The API breakages: a) Removed `MempoolFeeMiddleware` and `TxPriorityMiddleware`, the functionalities are moved into `DeductFeeMiddleware`, b) Added a `FeeMarket` field to `HandlerOptions`, and a `FeeMarket` parameter to `DeductFeeMiddleware`, when set to `StaticFeeMarket{}`, it'll keep the existing behavior, c) Added an `extention_options` field to `AuthInfo` in `Tx`, d) Added a `NewAuthExtensionOptionsMiddleware` middleware to check the `extension_options` field.
 
 
 ### Client Breaking Changes

proto/cosmos/tx/v1beta1/tx.proto

@@ -142,6 +142,11 @@ message AuthInfo {
   //
   // Since: cosmos-sdk 0.46
   Tip tip = 3;
+
+  // extension_options are arbitrary options that can be added by chains
+  // when the default options are not sufficient. If any of these are present
+  // and can't be handled, the transaction will be rejected
+  repeated google.protobuf.Any extension_options = 1023;
 }
 
 // SignerInfo describes the public key and signing mode of a single top-level

simapp/app.go

@@ -471,6 +471,7 @@ func (app *SimApp) setTxHandler(txConfig client.TxConfig, indexEventsStr []strin
 		SignModeHandler:  txConfig.SignModeHandler(),
 		SigGasConsumer:   authmiddleware.DefaultSigVerificationGasConsumer,
 		TxDecoder:        txConfig.TxDecoder(),
+		FeeMarket:        authmiddleware.StaticFeeMarket{},
 	})
 	if err != nil {
 		panic(err)

types/errors/errors.go

@@ -162,6 +162,9 @@ var (
 	// ErrAppConfig defines an error occurred if min-gas-prices field in BaseConfig is empty.
 	ErrAppConfig = Register(RootCodespace, 40, "error in app.toml")
 
+	// ErrUnknownAuthExtensionOptions defines an error for unknown auth_info extension options.
+	ErrUnknownAuthExtensionOptions = Register(RootCodespace, 41, "unknown auth_info extension options")
+
 	// ErrPanic is only set when we recover from a panic, so we know to
 	// redact potentially sensitive system info
 	ErrPanic = errorsmod.ErrPanic

types/tx/types.go

@@ -156,6 +156,12 @@ func (t *Tx) FeeGranter() sdk.AccAddress {
 	return nil
 }
 
+// AuthExtensionOptions returns the AuthInfo's ExtensionOptions,
+// implements the interface HasAuthExtensionOptionsTx.
+func (t *Tx) AuthExtensionOptions() []*codectypes.Any {
+	return t.AuthInfo.ExtensionOptions
+}
+
 // UnpackInterfaces implements the UnpackInterfaceMessages.UnpackInterfaces method
 func (t *Tx) UnpackInterfaces(unpacker codectypes.AnyUnpacker) error {
 	if t.Body != nil {