Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): support wrapped errors with gRPC codes #11385

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 15, 2022

Description

Follows up on #11274 to properly support wrapped errors.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

errors/errors.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #11385 (a51dc7e) into master (6f16d01) will increase coverage by 0.02%.
The diff coverage is 80.00%.

❗ Current head a51dc7e differs from pull request most recent head 5b2fdfd. Consider uploading reports for the commit 5b2fdfd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11385      +/-   ##
==========================================
+ Coverage   65.93%   65.96%   +0.02%     
==========================================
  Files         676      676              
  Lines       69962    69977      +15     
==========================================
+ Hits        46127    46157      +30     
+ Misses      21130    21113      -17     
- Partials     2705     2707       +2     
Impacted Files Coverage Δ
errors/errors.go 83.33% <80.00%> (-0.46%) ⬇️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 16, 2022
@mergify mergify bot merged commit d3163b8 into master Mar 16, 2022
@mergify mergify bot deleted the aaronc/fix-grpc-errors branch March 16, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants