fix(group): Update TresholdDecisionPolicy to handle threshold>totalWeight

[amaury1093]

Description

Closes: #10945

In ThresholdDecisionPolicy, allow the threshold to be arbitrarily big (e.g. bigger than the group total weight). In that case, in Allow(), the tally result is compared against min(threshold,total_weight).

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[amaury1093]

I'm adding DecisionPolicy.Validate() calls in a few places in the msg server:

• MsgCreateGroupPolicy and MsgCreateGroupWithPolicy
• MsgUpdateDecisionPolicy
• MsgLeaveGroup
• MsgUpdateGroupMembers

anywhere else you think we need to add validation?

[anilcse]

lgtm

Just a thought, can we use if allYesVotes instead of min(threshold,total_weight), that sounds safe for me.

[atheeshp]

Lgtm

[amaury1093]

Just a thought, can we use if allYesVotes instead of min(threshold,total_weight), that sounds safe for me.

@anilcse Could you explain your change in more details? e.g. which line?

[anilcse]

@AmauryM here can we just check if everyone voted yes instead of checking against realThreshold?

[amaury1093]

I see. There are 2 scenarios:

• if threshold>totalPower, then we should check that everyone votes yes
• if threshold<totalPower, we don't need everyone to vote yes

In the 2nd cases, we don't check everyone voted yes. The realThreshold is used to share logic to avoid having an if then else case, but I can introduce that if it's clearer.

[anilcse]

Ah yes. I don't have a strong preference now. Let's go with this unless anyone are strongly in favor of checking all-yes-votes for the special case. @blushi @robert-zaremba wdyt?