feat: add migration logs #11100
Closed
feat: add migration logs #11100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
approved these changes
Feb 2, 2022
Comment on lines
+460
to
+461
| ctx.Logger().Info(fmt.Sprintf("Running migration for module: %s, InitGenesis (on default genesis) toVersion %d", | ||
| moduleName, toVersion)) |
There was a problem hiding this comment.
Why not using key vals ?
There was a problem hiding this comment.
Suggested change
| ctx.Logger().Info(fmt.Sprintf("Running migration for module: %s, InitGenesis (on default genesis) toVersion %d", | |
| moduleName, toVersion)) | |
| ctx.Logger().Info(fmt.Sprintf("Adding new module and initializing default genesis", | |
| "module", moduleName, "target_version", toVersion)) |
There was a problem hiding this comment.
I think running migration makes more sense here. In most cases its a migration and not an add. Maybe we can say Running/Adding but it would be confusing.
tac0turtle
approved these changes
Feb 3, 2022
|
Q: why aren't we creating this on master and backporting? |
|
its already there #10768 |
|
closing this in favour of #11107. Please use the backport functionality in the future. its easier to track if its on master and easier for you as well |
cool! we just need a backport for gaia next release, I think I based off wrong brach (just get to know how sdk backport from amaurym ). thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11048
Next Gaia release will use cosmos-sdk 0.45, during the cosmoshub upgrade, it is helpful if validator can see the migration logs, so that validators can confirm that the upgrade is still in process.
we can make a backport release of v0.45.1 ?
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change