Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: link go.mod's to tagged errors/v1.0.0-beta.2 go.mod #10878

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 4, 2022

This links all of the other go.mod's in the SDK that need it to github.com/cosmos/cosmos-sdk/errors v1.0.0-beta.2 and also removes the dependency of the ORM on the SDK itself. Follow up to #10779.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

should we do a breakout discussion in discord on smaller packages vs a std package?

@aaronc
Copy link
Member Author

aaronc commented Jan 4, 2022

LGTM,

should we do a breakout discussion in discord on smaller packages vs a std package?

sure, want to kick that off?

@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Jan 4, 2022
@aaronc
Copy link
Member Author

aaronc commented Jan 4, 2022

Seems like #10879 needs to be merged first.

@aaronc aaronc changed the title chore: link go.mod's to tagged errors/v1.0.0-beta.1 go.mod chore: link go.mod's to tagged errors/v1.0.0-beta.2 go.mod Jan 4, 2022
@aaronc
Copy link
Member Author

aaronc commented Jan 4, 2022

Okay, I think that's fixed now

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #10878 (db69233) into master (401cf2f) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10878      +/-   ##
==========================================
+ Coverage   64.65%   64.88%   +0.22%     
==========================================
  Files         614      632      +18     
  Lines       58984    59901     +917     
==========================================
+ Hits        38139    38867     +728     
- Misses      18704    18835     +131     
- Partials     2141     2199      +58     
Impacted Files Coverage Δ
orm/encoding/ormkv/entry.go 69.81% <0.00%> (ø)
orm/encoding/ormfield/bytes.go 88.67% <0.00%> (ø)
orm/encoding/ormfield/uint32.go 100.00% <0.00%> (ø)
orm/encoding/ormfield/bool.go 81.48% <0.00%> (ø)
orm/encoding/ormfield/enum.go 80.00% <0.00%> (ø)
orm/encoding/ormfield/int64.go 100.00% <0.00%> (ø)
orm/encoding/ormkv/util.go 100.00% <0.00%> (ø)
orm/encoding/ormfield/uint64.go 100.00% <0.00%> (ø)
orm/encoding/ormfield/int32.go 100.00% <0.00%> (ø)
orm/encoding/ormkv/unique_key.go 69.56% <0.00%> (ø)
... and 8 more

@aaronc aaronc merged commit 074c95b into master Jan 5, 2022
@aaronc aaronc deleted the aaronc/errors-mod-dep branch January 5, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants