fix: .github/workflows retrofit to use Go modules #10382
Conversation
tac0turtle
added
the
A:automerge
| - name: Create a file with all the pkgs | ||
| run: go list ./... > pkgs.txt | ||
| run: find . -name "go.mod" | grep -v cosmovisor | while read F;do cd $(dirname $F);go list ./...;cd $OLDPWD;done >> pkgs.txt |
There was a problem hiding this comment.
how this is different to the originating PR? https://github.com/cosmos/cosmos-sdk/pull/10325/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R76
There was a problem hiding this comment.
Thanks for digging into it.
However we need to think a bit more. This doesn't solve the problems discussed in the original PR. As an evidence - look at the failing tests.
| @@ -115,7 +119,7 @@ jobs: | |||
| if: env.GIT_DIFF | |||
| - name: test & coverage report creation | |||
| run: | | |||
| cat pkgs.txt.part.${{ matrix.part }} | xargs go test -mod=readonly -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='norace ledger test_ledger_mock' | |||
| cat pkgs.txt.part.${{ matrix.part }} && cat pkgs.txt.part.${{ matrix.part }} | while read pkg;do go test -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='norace ledger test_ledger_mock' $pkg;done | |||
There was a problem hiding this comment.
This doesn't work for the same reason noted in #10325 (comment).
https://github.com/cosmos/cosmos-sdk/pull/10325/files#r729729294 I was thinking to do more traversal approach. I will dig more in my PR.
|
Could you check my comment: #10325 (comment) |
Fixes #10319