docs: Added staking client docs. #10306
Conversation
|
@juggernaut09 thank you for your contribution, did you want a review? You can move the PR from draft to Ready for Review |
|
Hi @barriebyron, I would like to add grpc and REST clients docs as well. In the Interim, Please review the CLI Client commands. Regards. |
There was a problem hiding this comment.
hi @juggernaut09 thank you for this fine work! I did not review for technical accuracy, but did make suggestions for editorial fixes. Do you know about adding the changes in batch? see https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request
…dk into 10292-staking-docs
|
Hi @barriebyron , I have resolved the above mentioned suggestions in this commit. |
There was a problem hiding this comment.
Editorial approval from me, thanks @juggernaut09
However, I cannot approve technical content and leave that review to the codeowners
thanks everyone!
|
hey, thanks for the contribution!! It looks good. nit: Could you add some docs on rest and/or grpc? |
|
Hi, @marbar3778. Thanks for reviewing. I have added the gRPC docs in this commit. I will add the REST docs in the further commits. Interim please review the gRPC docs. Regards. |
|
looks good!! thank you for making the change so quickly. |
|
Hi, @barriebyron @marbar3778 @aaronc @alexanderbez @anilcse .Added the CLI, gRPC and REST client docs for staking module in this commit. Please review it. Regards. |
tac0turtle
added
the
A:automerge
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: cosmos#10292 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
|
congratulations @juggernaut09, be sure to fill out the Contributor Details form to order your swag. |
Description
Closes: #10292
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change