-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(authz): fix typo and minor edits in spec/01_concepts.md #10195
Conversation
fixed a typo and made some minor edits while I was in here let's add the "hey, at a glance you might think this is auth, but no, it's authz" note for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
I noticed another typo on line 31 that would be nice to fix here:
- `spent_limit` keeps track of how many coins are left in the authorization.
This should be spend_limit
. Can you add the fix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (would like to see Ryan's fix above too in this PR)
yes! Co-authored-by: Amaury <[email protected]>
Visit https://dashboard.github.orijtech.com?back=0&pr=10195&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
thanks for catching this typo @ryanchristo
fixed a typo and made some minor edits while I was in here
let's add the "hey, at a glance you might think this is auth, but no, it's authz" note for clarity
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change