Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(authz): fix typo and minor edits in spec/01_concepts.md #10195

Merged
merged 4 commits into from
Sep 20, 2021

Conversation

barriebyron
Copy link
Contributor

fixed a typo and made some minor edits while I was in here
let's add the "hey, at a glance you might think this is auth, but no, it's authz" note for clarity

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

fixed a typo and made some minor edits while I was in here
let's add the "hey, at a glance you might think this is auth, but no, it's authz" note for clarity
Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

I noticed another typo on line 31 that would be nice to fix here:

- `spent_limit` keeps track of how many coins are left in the authorization.

This should be spend_limit. Can you add the fix here?

@ryanchristo ryanchristo changed the title fix:(doc x/authz/spec/01_concepts.md) fix typo and minor edits docs(authz): fix typo and minor edits in spec/01_concepts.md Sep 17, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (would like to see Ryan's fix above too in this PR)

x/authz/spec/01_concepts.md Outdated Show resolved Hide resolved
@orijbot
Copy link

orijbot commented Sep 20, 2021

thanks for catching this typo @ryanchristo
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 20, 2021
@mergify mergify bot merged commit c42acd6 into master Sep 20, 2021
@mergify mergify bot deleted the barriebyron-patch-authz branch September 20, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants