-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make chain-id flag not strictly required for tx commands #10184
Conversation
Visit https://dashboard.github.orijtech.com?back=0&pr=10184&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could you add a changelog entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending on changelog
Codecov Report
@@ Coverage Diff @@
## master #10184 +/- ##
=======================================
Coverage 63.72% 63.73%
=======================================
Files 573 573
Lines 53766 53764 -2
=======================================
+ Hits 34263 34264 +1
+ Misses 17555 17552 -3
Partials 1948 1948
|
Description
chain-id's can be specified in a client config to be used in CLI commands. This PR changes the ChainID flag to no longer be explicitly required, as this value can come from clientCtx via config.
Closes: #9644
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change