Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: encode/decode transaction #10133

Merged
merged 4 commits into from
Sep 14, 2021
Merged

docs: encode/decode transaction #10133

merged 4 commits into from
Sep 14, 2021

Conversation

ryanchristo
Copy link
Contributor

Description

Closes: #10102

Adds examples for encoding/decoding a transaction using the CLI. Also fixes CLI use and description.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #10133 (d7d4603) into master (6fc79b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d7d4603 differs from pull request most recent head 9fad221. Consider uploading reports for the commit 9fad221 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10133   +/-   ##
=======================================
  Coverage   63.62%   63.63%           
=======================================
  Files         573      573           
  Lines       53606    53606           
=======================================
+ Hits        34109    34110    +1     
+ Misses      17550    17549    -1     
  Partials     1947     1947           
Impacted Files Coverage Δ
x/auth/client/cli/decode.go 60.00% <100.00%> (ø)
x/auth/client/cli/encode.go 76.00% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@ryanchristo ryanchristo marked this pull request as ready for review September 14, 2021 03:23
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 14, 2021
@orijbot
Copy link

orijbot commented Sep 14, 2021

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot merged commit a70f39e into master Sep 14, 2021
@mergify mergify bot deleted the ryan/10102-encode-decode branch September 14, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode/Decode Transaction Documentation
4 participants