-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unmarshalling issue with multisig keys in master (backport #10061) #10113
Merged
amaury1093
merged 10 commits into
release/v0.42.x
from
mergify/bp/release/v0.42.x/pr-10061
Nov 9, 2021
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
240c317
fix: unmarshalling issue with multisig keys in master (#10061)
haasted 1a41383
fix conflicts
alexanderbez 04b5c7e
fix conflicts
alexanderbez ae70213
Update crypto/keys/multisig/multisig_test.go
amaury1093 d84bc05
Removed unused imports
amaury1093 3b24a9a
Merge branch 'release/v0.42.x' into mergify/bp/release/v0.42.x/pr-10061
robert-zaremba c1d4b9c
fix changelog
robert-zaremba eff1b17
Merge branch 'release/v0.42.x' into mergify/bp/release/v0.42.x/pr-10061
robert-zaremba 2d90f2b
Update CHANGELOG.md
robert-zaremba 6964dd0
Fix TestLegacyMultisig test (#10275)
blewater File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this fix is not correct. Reading the comment just above, we actually don't want to create new Anys, because we want to keep the existing Anys'
.compat
field.The unmarshalling error comes from the fact that
.compat
is empty on the new Anys.